WIP: Build all blas-metapackages in this feedstock (also for netlib)#68
WIP: Build all blas-metapackages in this feedstock (also for netlib)#68h-vetinari wants to merge 5 commits into
Conversation
h-vetinari
requested review from
isuruf,
jakirkham,
ocefpaf and
pelson
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
| {% set build_num = 8 %} | ||
| {% set version_major = version.split(".")[0] %} | ||
| {% set blas_major = "2" %} | ||
| {% set blas_major = "3" %} |
There was a problem hiding this comment.
not sure if this is really necessary; it's a rather small change in the conda-forge blas infrastructure, but a change nevertheless. But it's perhaps not a bad idea to start with a clean slate - there were some collisions on this between 3.8.0 & 3.9.0 until blas_minor got introduced recently.
There was a problem hiding this comment.
But it's perhaps not a bad idea to start with a clean slate
That's not a good enough reason to rebuild all downstream packages. Changing the major version will require a rebuild of all downstream packages.
There was a problem hiding this comment.
Wasn't aware that this requires a rebuild, agreed that that's not worth it.
| # netlib builds are build in lapack-feedstock | ||
| - pin_run_as_build('libblas', exact=True) # [blas_impl == 'netlib'] | ||
| - pin_run_as_build('libcblas', exact=True) # [blas_impl == 'netlib'] | ||
| - pin_run_as_build('liblapack', exact=True) # [blas_impl == 'netlib'] | ||
| - pin_run_as_build('liblapacke', exact=True) # [blas_impl == 'netlib'] |
h-vetinari
changed the title
isuruf
left a comment
isuruf
left a comment
There was a problem hiding this comment.
How is this going to work when there's a new version?
The other variants needs the netlib variant and therefore builds will fail
It work work the same as now - the netlib variants of |
|
Based on the docs for |
|
This is becoming complex and messy. I don't like it. I don't see what benefits we would have. One mistake doesn't make sense to make this complex and messy. |
3 participants
Fixes #66, cc @minrk
Note that in the lapack-feedstock,
blas-develdepends onblas, while in this feedstock, it is the other way around. I kept asking about this in #62 & #65 (because to me, the-develversion should contain more than the default), but got no answer. Still, I'm assuming that @isuruf knows very well what he's doing, so I've kept the relationship from this feedstock.